Abstraction overload

Abstraction overload

Postby Centry on Fri Apr 13, 2007 11:49 am

Abstraction is good and clean, but Lifetype has an abstraction overflow.
This software is unsupportable.
Even by tracing on from summary.php to find out how to use op=display your are not able to follow methods and classes to get target params.
Boys, you tried things you dont know.
Clean up your code, get a good documentation and try again.
The basics of LifeType are good, but your coding style is horrible.
No safe_mode on support, undocumented self-references, and untraceable methods and code.
Learn how to use PHP5 and try again, sorry being that hard.
Posts: 1
Joined: Fri Apr 13, 2007 11:44 am

Postby phunkphorce on Fri Apr 13, 2007 3:50 pm

Perhaps you should try to understand the idea of Model-View-Controller first and then go back to our code. I don't think the idea of controller->action class->view class is too difficult to follow, specially considering that the file class/summary/controller/summarycontroller.class.php (instantiated from summary.php) has a list that maps values of the "op" parameter to action classes. You're probably looking for this, right?

Code: Select all
"display" => "SummaryCustomPageAction"

About PHP 5, LifeType was started over 3 years ago when PHP 5 had not even been released. And since PHP 4 is still more popular than PHP 5, we're still supporting it (and we will be for some time to come)

In any case, you're free not to use LifeType. And if you have further feedback, please be more specific. You're criticizing our code but don't point to any specific example, and we haven't even seen your code either...
Lifetype Expert
Posts: 9028
Joined: Mon Aug 25, 2003 6:34 am
Location: Suomessa

Re: Abstraction overload

Postby reto on Sun Apr 15, 2007 6:13 am

Centry wrote:Clean up your code, get a good documentation and try again.

well, cleaning up is always a good idea. Especially in spring :). We usually try to write clean code, although we do not have very strict coding guidelines.

Regarding documentation: I think we're doing a pretty good job in documenting our code. You may have missed our API documentation, which can help a lot if you're new to LifeType.
reto | wiki | Downloads
Lifetype Expert
Posts: 395
Joined: Sat Apr 17, 2004 12:34 pm

Return to LifeType 2.0 Development